s390/qdio: use atomic_cmpxchg

qdio uses atomic_read to find an unused indicator and atomic_set to
flag it as used. This could lead to multiple users getting the same
indicator. Use atomic_cmpxchg instead.

Signed-off-by: Sebastian Ott <[email protected]>
Acked-by: Ursula Braun <[email protected]>
Signed-off-by: Martin Schwidefsky <[email protected]>

diff --git a/drivers/s390/cio/qdio_thinint.c b/drivers/s390/cio/qdio_thinint.c
index c61164f4528e1230c4e980b66ba7e2af1d2e9941..3e587bf426b0ef09b5f6d0804ae2b378e0a8ab09 100644 (file)
--- a/drivers/s390/cio/qdio_thinint.c
+++ b/drivers/s390/cio/qdio_thinint.c
@@ -56,10 +56,8 @@ static u32 *get_indicator(void)
        int i;
 
        for (i = 0; i < TIQDIO_NR_NONSHARED_IND; i++)
-               if (!atomic_read(&q_indicators[i].count)) {
-                       atomic_set(&q_indicators[i].count, 1);
+               if (!atomic_cmpxchg(&q_indicators[i].count, 0, 1))
                        return &q_indicators[i].ind;
-               }
 
        /* use the shared indicator */
        atomic_inc(&q_indicators[TIQDIO_SHARED_IND].count);