ipv6: Fix inet6_csk_bind_conflict()

Commit fda48a0d7a84 (tcp: bind() fix when many ports are bound)
introduced a bug on IPV6 part.
We should not call ipv6_addr_any(inet6_rcv_saddr(sk2)) but
ipv6_addr_any(inet6_rcv_saddr(sk)) because sk2 can be IPV4, while sk is
IPV6.

Reported-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Eric Dumazet <[email protected]>
Tested-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c
index b4b7d40a9c95a74479d0b6af834075740764d664..3a4d92b5a83e5586ff4201e2cc3abfac1caf4ead 100644 (file)
--- a/net/ipv6/inet6_connection_sock.c
+++ b/net/ipv6/inet6_connection_sock.c
@@ -48,7 +48,7 @@ int inet6_csk_bind_conflict(const struct sock *sk,
                             ipv6_rcv_saddr_equal(sk, sk2))
                                break;
                        else if (sk->sk_reuse && sk2->sk_reuse &&
-                               !ipv6_addr_any(inet6_rcv_saddr(sk2)) &&
+                               !ipv6_addr_any(inet6_rcv_saddr(sk)) &&
                                ipv6_rcv_saddr_equal(sk, sk2))
                                break;
                }