ixgbe: check for vfs outside of sriov_num_vfs before dereference

The check for vfinfo is not sufficient because it does not protect
against specifying vf that is outside of sriov_num_vfs range.
All of the ndo functions have a check for it except for
ixgbevf_ndo_set_spoofcheck().

The following patch is all we need to protect against this panic:

ip link set p96p1 vf 0 spoofchk off
BUG: unable to handle kernel NULL pointer dereference at 0000000000000052
IP: [<ffffffffa044a1c1>]
ixgbe_ndo_set_vf_spoofchk+0x51/0x150 [ixgbe]

Reported-by: Thierry Herbelot <[email protected]>
Signed-off-by: Emil Tantilov <[email protected]>
Acked-by: Thierry Herbelot <[email protected]>
Signed-off-by: Jeff Kirsher <[email protected]>

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
index 706fc69aa0c51d3824d7c7e8ed0d47ff8f7adbe9..97c85b859536bf1bfd0aa7b3e323dfd7a28e00b1 100644 (file)
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
@@ -1261,6 +1261,9 @@ int ixgbe_ndo_set_vf_spoofchk(struct net_device *netdev, int vf, bool setting)
        struct ixgbe_hw *hw = &adapter->hw;
        u32 regval;
 
+       if (vf >= adapter->num_vfs)
+               return -EINVAL;
+
        adapter->vfinfo[vf].spoofchk_enabled = setting;
 
        regval = IXGBE_READ_REG(hw, IXGBE_PFVFSPOOF(vf_target_reg));