mac80211: decrement ref count to netdev after launching mesh discovery
authorBrian Cavagnolo <[email protected]>
Sat, 17 Jan 2009 03:04:49 +0000 (19:04 -0800)
committerJohn W. Linville <[email protected]>
Thu, 22 Jan 2009 18:55:00 +0000 (13:55 -0500)
After launching mesh discovery in tx path, reference count was not being
decremented.  This was preventing module unload.

Signed-off-by: Brian Cavagnolo <[email protected]>
Signed-off-by: Andrey Yurovsky <[email protected]>
Acked-by: Johannes Berg <[email protected]>
Signed-off-by: John W. Linville <[email protected]>
net/mac80211/tx.c

index a4af3a124cce7d895426b9e49e36ef53a5c54601..4278e545638fbeae16c5ffd0795a4835a4358c21 100644 (file)
@@ -1307,8 +1307,10 @@ int ieee80211_master_start_xmit(struct sk_buff *skb, struct net_device *dev)
                if (is_multicast_ether_addr(hdr->addr3))
                        memcpy(hdr->addr1, hdr->addr3, ETH_ALEN);
                else
-                       if (mesh_nexthop_lookup(skb, osdata))
-                               return  0;
+                       if (mesh_nexthop_lookup(skb, osdata)) {
+                               dev_put(odev);
+                               return 0;
+                       }
                if (memcmp(odev->dev_addr, hdr->addr4, ETH_ALEN) != 0)
                        IEEE80211_IFSTA_MESH_CTR_INC(&osdata->u.mesh,
                                                            fwded_frames);