dmaengine: bcm-sba-raid: serialize dma_cookie_complete() using reqs_lock

As-per documentation in driver/dma/dmaengine.h, the
dma_cookie_complete() API should be called with lock
held.

This patch ensures that Broadcom SBA RAID driver calls
the dma_cookie_complete() API with reqs_lock held.

Signed-off-by: Anup Patel <[email protected]>
Reviewed-by: Ray Jui <[email protected]>
Reviewed-by: Scott Branden <[email protected]>
Signed-off-by: Vinod Koul <[email protected]>

diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
index 6c2c44724637282d9b5b5d1a27bca0b1a1b164b0..15c558508345a30a1168af55bebda470e3af2678 100644 (file)
--- a/drivers/dma/bcm-sba-raid.c
+++ b/drivers/dma/bcm-sba-raid.c
@@ -442,7 +442,9 @@ static void sba_process_received_request(struct sba_device *sba,
 
                WARN_ON(tx->cookie < 0);
                if (tx->cookie > 0) {
+                       spin_lock_irqsave(&sba->reqs_lock, flags);
                        dma_cookie_complete(tx);
+                       spin_unlock_irqrestore(&sba->reqs_lock, flags);
                        dmaengine_desc_get_callback_invoke(tx, NULL);
                        dma_descriptor_unmap(tx);
                        tx->callback = NULL;