gpio: mt7621: report failure of devm_kasprintf()

kasprintf() may return NULL on failure of internal allocation thus the
assigned  label  is not safe if not explicitly checked. On error
mediatek_gpio_bank_probe() returns negative values so -ENOMEM in the
(unlikely) failure case should be fine here.

Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621")
Signed-off-by: Nicholas Mc Guire <[email protected]>
Reviewed-by: Bartosz Golaszewski <[email protected]>
Acked-by: Sean Wang <[email protected]>
Signed-off-by: Linus Walleij <[email protected]>

diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c
index d72af6f6cdbda0870266b7531c878f7a2f954968..1ec95bc18f5ba6747e3942f3efaa75b847a22c7d 100644 (file)
--- a/drivers/gpio/gpio-mt7621.c
+++ b/drivers/gpio/gpio-mt7621.c
@@ -244,6 +244,8 @@ mediatek_gpio_bank_probe(struct device *dev,
        rg->chip.of_xlate = mediatek_gpio_xlate;
        rg->chip.label = devm_kasprintf(dev, GFP_KERNEL, "%s-bank%d",
                                        dev_name(dev), bank);
+       if (!rg->chip.label)
+               return -ENOMEM;
 
        ret = devm_gpiochip_add_data(dev, &rg->chip, mtk);
        if (ret < 0) {