net: tsec: Fix memory leak in error path

tsec_initialize allocates a private driver structure using malloc.
Should the memory allocation of this private structure fail, the
function execution is aborted with a return 0, but the previously
allocated device structure is never freed, hence leaked.

Free the device structure in the error case.

Signed-off-by: Mario Six <[email protected]>
Acked-by: Joe Hershberger <[email protected]>

diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
index 071595218e9737ae472285e5b7871fcc82ed5694..44140fb0374b636f2b2884447cc1020abaf9b808 100644 (file)
--- a/drivers/net/tsec.c
+++ b/drivers/net/tsec.c
@@ -701,8 +701,10 @@ static int tsec_initialize(bd_t *bis, struct tsec_info_struct *tsec_info)
 
        priv = (struct tsec_private *)malloc(sizeof(*priv));
 
-       if (!priv)
+       if (!priv) {
+               free(dev);
                return 0;
+       }
 
        priv->regs = tsec_info->regs;
        priv->phyregs_sgmii = tsec_info->miiregs_sgmii;