drm/radeon: use after free in radeon_vm_bo_add()

"bo_va" is dereferenced in the error message.

Signed-off-by: Dan Carpenter <[email protected]>
Signed-off-by: Dave Airlie <[email protected]>

diff --git a/drivers/gpu/drm/radeon/radeon_gart.c b/drivers/gpu/drm/radeon/radeon_gart.c
index 8597d2c016e672fd2b127464a8adbd4285616276..a97baf5c114fa5f8304d636e5208b9f5577ef519 100644 (file)
--- a/drivers/gpu/drm/radeon/radeon_gart.c
+++ b/drivers/gpu/drm/radeon/radeon_gart.c
@@ -494,10 +494,10 @@ int radeon_vm_bo_add(struct radeon_device *rdev,
                }
                if (bo_va->soffset >= tmp->soffset && bo_va->soffset < tmp->eoffset) {
                        /* bo and tmp overlap, invalid offset */
-                       kfree(bo_va);
                        dev_err(rdev->dev, "bo %p va 0x%08X conflict with (bo %p 0x%08X 0x%08X)\n",
                                bo, (unsigned)bo_va->soffset, tmp->bo,
                                (unsigned)tmp->soffset, (unsigned)tmp->eoffset);
+                       kfree(bo_va);
                        mutex_unlock(&vm->mutex);
                        return -EINVAL;
                }