net/wan/fsl_ucc_hdlc: call qe_setbrg only for loopback mode

We can't assume that we are always in loopback mode if rx and tx clock
have the same clock source. If we want to use HDLC busmode we also have
the same clock source but we are not in loopback mode. So move the
setting of the baudrate generator after the check for property for the
loopback mode.

Signed-off-by: Holger Brunck <[email protected]>
Cc: Zhao Qiang <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
index 49b91b2c113ca3f1ad5c100c560d64b3a07edb9f..4c93d561b18ab435ae9d6c1c77534c44395d7a43 100644 (file)
--- a/drivers/net/wan/fsl_ucc_hdlc.c
+++ b/drivers/net/wan/fsl_ucc_hdlc.c
@@ -113,6 +113,9 @@ static int uhdlc_init(struct ucc_hdlc_private *priv)
        /* Loopback mode */
        if (priv->loopback) {
                dev_info(priv->dev, "Loopback Mode\n");
+               /* use the same clock when work in loopback */
+               qe_setbrg(ut_info->uf_info.rx_clock, 20000000, 1);
+
                gumr = ioread32be(&priv->uf_regs->gumr);
                gumr |= (UCC_FAST_GUMR_LOOPBACK | UCC_FAST_GUMR_CDS |
                         UCC_FAST_GUMR_TCI);
@@ -1021,10 +1024,6 @@ static int ucc_hdlc_probe(struct platform_device *pdev)
                return -EINVAL;
        }
 
-       /* use the same clock when work in loopback */
-       if (ut_info->uf_info.rx_clock == ut_info->uf_info.tx_clock)
-               qe_setbrg(ut_info->uf_info.rx_clock, 20000000, 1);
-
        ret = of_address_to_resource(np, 0, &res);
        if (ret)
                return -EINVAL;