coresight: platform: Fix leaking device reference

We don't drop the reference on the remote device while parsing the
connection, held by bus_find_device(). Fix this by duplicating the
device name and dropping the reference.

Cc: Mathieu Poirier <[email protected]>
Cc: Kim Phillips <[email protected]>
Signed-off-by: Suzuki K Poulose <[email protected]>
Signed-off-by: Mathieu Poirier <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c
index 28d3aef1660b4d787910d4dcdca540ebbbcc6b9f..4b279f8fea0c88d1150ba3655cd87c9980edf9b7 100644 (file)
--- a/drivers/hwtracing/coresight/of_coresight.c
+++ b/drivers/hwtracing/coresight/of_coresight.c
@@ -162,7 +162,9 @@ static int of_coresight_parse_endpoint(struct device *dev,
                }
 
                pdata->outports[i] = endpoint.port;
-               pdata->child_names[i] = dev_name(rdev);
+               pdata->child_names[i] = devm_kstrdup(dev,
+                                                    dev_name(rdev),
+                                                    GFP_KERNEL);
                pdata->child_ports[i] = rendpoint.id;
                /* Connection record updated */
                ret = 1;
@@ -172,6 +174,8 @@ static int of_coresight_parse_endpoint(struct device *dev,
                of_node_put(rparent);
        if (rport)
                of_node_put(rport);
+       if (rdev)
+               put_device(rdev);
 
        return ret;
 }