projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
be35ffa
)
renesas: missing unlock on error path
author
Dan Carpenter
<
[email protected]
>
Wed, 24 Jun 2015 14:32:54 +0000
(17:32 +0300)
committer
David S. Miller
<
[email protected]
>
Thu, 25 Jun 2015 09:13:02 +0000
(
02:13
-0700)
We need to unlock before returning here.
Fixes: a0d2f20650e8 ('Renesas Ethernet AVB PTP clock driver')
Signed-off-by: Dan Carpenter <
[email protected]
>
Acked-by: Sergei Shtylyov <
[email protected]
>
Signed-off-by: David S. Miller <
[email protected]
>
drivers/net/ethernet/renesas/ravb_ptp.c
patch
|
blob
|
history
diff --git
a/drivers/net/ethernet/renesas/ravb_ptp.c
b/drivers/net/ethernet/renesas/ravb_ptp.c
index 42656da5050063ca382a6bb24375ec08ff672385..7a8ce920c49e709b067321ae91306153f4f24390 100644
(file)
--- a/
drivers/net/ethernet/renesas/ravb_ptp.c
+++ b/
drivers/net/ethernet/renesas/ravb_ptp.c
@@
-116,8
+116,10
@@
static int ravb_ptp_adjfreq(struct ptp_clock_info *ptp, s32 ppb)
priv->ptp.current_addend = addend;
gccr = ravb_read(ndev, GCCR);
- if (gccr & GCCR_LTI)
+ if (gccr & GCCR_LTI) {
+ spin_unlock_irqrestore(&priv->lock, flags);
return -EBUSY;
+ }
ravb_write(ndev, addend & GTI_TIV, GTI);
ravb_write(ndev, gccr | GCCR_LTI, GCCR);