Input: gpio-keys - switch to bitmap_zalloc()

Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.

Signed-off-by: Andy Shevchenko <[email protected]>
Signed-off-by: Dmitry Torokhov <[email protected]>

diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index 052e37675086bf53bc7d471d0434542167c6a88e..492a971b95b56728c84dac932432c12a56bc737b 100644 (file)
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -196,7 +196,7 @@ static ssize_t gpio_keys_attr_show_helper(struct gpio_keys_drvdata *ddata,
        ssize_t ret;
        int i;
 
-       bits = kcalloc(BITS_TO_LONGS(n_events), sizeof(*bits), GFP_KERNEL);
+       bits = bitmap_zalloc(n_events, GFP_KERNEL);
        if (!bits)
                return -ENOMEM;
 
@@ -216,7 +216,7 @@ static ssize_t gpio_keys_attr_show_helper(struct gpio_keys_drvdata *ddata,
        buf[ret++] = '\n';
        buf[ret] = '\0';
 
-       kfree(bits);
+       bitmap_free(bits);
 
        return ret;
 }
@@ -240,7 +240,7 @@ static ssize_t gpio_keys_attr_store_helper(struct gpio_keys_drvdata *ddata,
        ssize_t error;
        int i;
 
-       bits = kcalloc(BITS_TO_LONGS(n_events), sizeof(*bits), GFP_KERNEL);
+       bits = bitmap_zalloc(n_events, GFP_KERNEL);
        if (!bits)
                return -ENOMEM;
 
@@ -284,7 +284,7 @@ static ssize_t gpio_keys_attr_store_helper(struct gpio_keys_drvdata *ddata,
        mutex_unlock(&ddata->disable_lock);
 
 out:
-       kfree(bits);
+       bitmap_free(bits);
        return error;
 }