vhost_net: stop device during reset owner
authorJason Wang <[email protected]>
Thu, 25 Jan 2018 14:03:52 +0000 (22:03 +0800)
committerDavid S. Miller <[email protected]>
Mon, 29 Jan 2018 17:26:20 +0000 (12:26 -0500)
We don't stop device before reset owner, this means we could try to
serve any virtqueue kick before reset dev->worker. This will result a
warn since the work was pending at llist during owner resetting. Fix
this by stopping device during owner reset.

Reported-by: [email protected]
Fixes: 3a4d5c94e9593 ("vhost_net: a kernel-level virtio server")
Signed-off-by: Jason Wang <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
drivers/vhost/net.c

index 7baa90abe0970211892e1c771adeeb95ffae2347..80323948c0ddda0016732ece87022b4dc22c7e7f 100644 (file)
@@ -1227,6 +1227,7 @@ static long vhost_net_reset_owner(struct vhost_net *n)
        }
        vhost_net_stop(n, &tx_sock, &rx_sock);
        vhost_net_flush(n);
+       vhost_dev_stop(&n->dev);
        vhost_dev_reset_owner(&n->dev, umem);
        vhost_net_vq_reset(n);
 done: