projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8180bd4
)
brcmfmac: fix error handling of irq_of_parse_and_map
author
Dmitry Torokhov
<
[email protected]
>
Fri, 14 Nov 2014 22:12:21 +0000
(14:12 -0800)
committer
John W. Linville
<
[email protected]
>
Mon, 17 Nov 2014 20:04:04 +0000
(15:04 -0500)
Return value of irq_of_parse_and_map() is unsigned int, with 0
indicating failure, so testing for negative result never works.
Signed-off-by: Dmitry Torokhov <
[email protected]
>
Cc:
[email protected]
# v3.17
Acked-by: Arend van Spriel <
[email protected]
>
Signed-off-by: John W. Linville <
[email protected]
>
drivers/net/wireless/brcm80211/brcmfmac/of.c
patch
|
blob
|
history
diff --git
a/drivers/net/wireless/brcm80211/brcmfmac/of.c
b/drivers/net/wireless/brcm80211/brcmfmac/of.c
index f05f5270fec1095df589b96490308bfe5193568a..927bffd5be6487125ca5f3e269b5eb0d690fb2f7 100644
(file)
--- a/
drivers/net/wireless/brcm80211/brcmfmac/of.c
+++ b/
drivers/net/wireless/brcm80211/brcmfmac/of.c
@@
-40,8
+40,8
@@
void brcmf_of_probe(struct brcmf_sdio_dev *sdiodev)
return;
irq = irq_of_parse_and_map(np, 0);
- if (
irq < 0
) {
- brcmf_err("interrupt could not be mapped
: err=%d\n", irq
);
+ if (
!irq
) {
+ brcmf_err("interrupt could not be mapped
\n"
);
devm_kfree(dev, sdiodev->pdata);
return;
}