V4L/DVB: drivers/media/video/pvrusb2: Add missing mutex_unlock

Add a mutex_unlock missing on the error path.  In the other functions in
the same file the locks and unlocks of this mutex appear to be balanced,
so it would seem that the same should hold in this case.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression E1;
@@

* mutex_lock(E1,...);
  <+... when != E1
  if (...) {
    ... when != E1
*   return ...;
  }
  ...+>
* mutex_unlock(E1,...);
// </smpl>

Signed-off-by: Julia Lawall <[email protected]>
Signed-off-by: Douglas Schilling Landgraf <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

diff --git a/drivers/media/video/pvrusb2/pvrusb2-ioread.c b/drivers/media/video/pvrusb2/pvrusb2-ioread.c
index b4824782d858c9c8626c791405c822ba363e64af..bba6115c9ae88187be7edf0494e8911fd0754995 100644 (file)
--- a/drivers/media/video/pvrusb2/pvrusb2-ioread.c
+++ b/drivers/media/video/pvrusb2/pvrusb2-ioread.c
@@ -223,7 +223,10 @@ int pvr2_ioread_setup(struct pvr2_ioread *cp,struct pvr2_stream *sp)
                                   " pvr2_ioread_setup (setup) id=%p",cp);
                        pvr2_stream_kill(sp);
                        ret = pvr2_stream_set_buffer_count(sp,BUFFER_COUNT);
-                       if (ret < 0) return ret;
+                       if (ret < 0) {
+                               mutex_unlock(&cp->mutex);
+                               return ret;
+                       }
                        for (idx = 0; idx < BUFFER_COUNT; idx++) {
                                bp = pvr2_stream_get_buffer(sp,idx);
                                pvr2_buffer_set_buffer(bp,