MIPS: Lasat: Replace del_timer by del_timer_sync
authorJulia Lawall <[email protected]>
Wed, 26 Mar 2014 21:33:43 +0000 (22:33 +0100)
committerRalf Baechle <[email protected]>
Mon, 31 Mar 2014 16:17:12 +0000 (18:17 +0200)
Use del_timer_sync to ensure that the timer is stopped on all CPUs before
the driver exists.

This change was suggested by Thomas Gleixner

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
declarer name module_exit;
identifier ex;
@@

module_exit(ex);

@@
identifier r.ex;
@@

ex(...) {
  <...
- del_timer
+ del_timer_sync
    (...)
  ...>
}
// </smpl>

Signed-off-by: Julia Lawall <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Patchwork: https://patchwork.linux-mips.org/patch/6663/
Signed-off-by: Ralf Baechle <[email protected]>
arch/mips/lasat/picvue_proc.c

index 638c5db122c924dca997725d58ee0fd34b36fe1b..2bcd8391bc93a0e9b0505c9e862038ecfcbb11d8 100644 (file)
@@ -175,7 +175,7 @@ static void pvc_proc_cleanup(void)
        remove_proc_entry("scroll", pvc_display_dir);
        remove_proc_entry(DISPLAY_DIR_NAME, NULL);
 
-       del_timer(&timer);
+       del_timer_sync(&timer);
 }
 
 static int __init pvc_proc_init(void)