projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
9c586a4
)
staging:iio:ad7887: Do not return error code in interrupt handler
author
Lars-Peter Clausen
<
[email protected]
>
Wed, 4 Jul 2012 16:09:00 +0000
(17:09 +0100)
committer
Jonathan Cameron
<
[email protected]
>
Sun, 8 Jul 2012 19:02:28 +0000
(20:02 +0100)
The interrupt handler should only ever return one of the three irqreturn_t
constants and not an error code. Also make sure to always call
iio_trigger_notify_done before leaving the trigger handler.
Signed-off-by: Lars-Peter Clausen <
[email protected]
>
Signed-off-by: Jonathan Cameron <
[email protected]
>
drivers/staging/iio/adc/ad7887_ring.c
patch
|
blob
|
history
diff --git
a/drivers/staging/iio/adc/ad7887_ring.c
b/drivers/staging/iio/adc/ad7887_ring.c
index 1c406dad0e67871c77d27632e316ce99167b65ff..c76fdb5081c2c9fed713becd14530b4eff944b63 100644
(file)
--- a/
drivers/staging/iio/adc/ad7887_ring.c
+++ b/
drivers/staging/iio/adc/ad7887_ring.c
@@
-82,7
+82,7
@@
static irqreturn_t ad7887_trigger_handler(int irq, void *p)
buf = kzalloc(indio_dev->scan_bytes, GFP_KERNEL);
if (buf == NULL)
-
return -ENOMEM
;
+
goto done
;
b_sent = spi_sync(st->spi, st->ring_msg);
if (b_sent)