pinctrl: ocelot: fix gpio direction

Bits have to be cleared in DEVCPU_GCB:GPIO:GPIO_OE for input and set for
output. ocelot_gpio_set_direction() got it wrong and this went unnoticed
when the driver was reworked.

Reported-by: Gregory Clement <[email protected]>
Signed-off-by: Alexandre Belloni <[email protected]>
Acked-by: Gregory CLEMENT <[email protected]>
Signed-off-by: Linus Walleij <[email protected]>

diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c
index a9423238471eeb479709bf2cf07f0bdb9891d556..b5b3547fdcb2bcf33c50cf3ebcb634de48994bb3 100644 (file)
--- a/drivers/pinctrl/pinctrl-ocelot.c
+++ b/drivers/pinctrl/pinctrl-ocelot.c
@@ -252,7 +252,7 @@ static int ocelot_gpio_set_direction(struct pinctrl_dev *pctldev,
        struct ocelot_pinctrl *info = pinctrl_dev_get_drvdata(pctldev);
 
        regmap_update_bits(info->map, OCELOT_GPIO_OE, BIT(pin),
-                          input ? BIT(pin) : 0);
+                          input ? 0 : BIT(pin));
 
        return 0;
 }