perf top: Fix annotation on --stdio
authorNamhyung Kim <[email protected]>
Fri, 11 Dec 2015 02:56:55 +0000 (11:56 +0900)
committerArnaldo Carvalho de Melo <[email protected]>
Fri, 11 Dec 2015 11:36:18 +0000 (08:36 -0300)
The ui__has_annotation() inside perf_top__record_precise_ip() should be
removed since it returns true only for TUI (and when sort key has
symbol).  However the 'perf top --stdio' also supports annotation for a
symbol which was specified by 's' key action.

Actually it already does the necessary checks before calling the
function.  So it's ok to get rid of the check here.

Signed-off-by: Namhyung Kim <[email protected]>
Cc: David Ahern <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
tools/perf/builtin-top.c

index 586798acf7db1132d7995afcfdd616419cd920a9..f447e5531f8b87473bc2e06a3be14bbce29f4e66 100644 (file)
@@ -189,8 +189,7 @@ static void perf_top__record_precise_ip(struct perf_top *top,
        if (pthread_mutex_trylock(&notes->lock))
                return;
 
-       if (ui__has_annotation())
-               err = hist_entry__inc_addr_samples(he, counter, ip);
+       err = hist_entry__inc_addr_samples(he, counter, ip);
 
        pthread_mutex_unlock(&notes->lock);