mmc: msm_sdcc: Fix a typo in MSM SDCC driver gpio setup
authorAlexander Tarasikov <[email protected]>
Sun, 21 Aug 2011 11:52:43 +0000 (15:52 +0400)
committerChris Ball <[email protected]>
Wed, 26 Oct 2011 19:43:36 +0000 (15:43 -0400)
The use of && instead of || caused a NULL pointer dereference if
gpio setup was not passed via platform data

Signed-off-by: Alexander Tarasikov <[email protected]>
Acked-by: Sahitya Tummala <[email protected]>
Signed-off-by: David Brown <[email protected]>
Signed-off-by: Chris Ball <[email protected]>
drivers/mmc/host/msm_sdcc.c

index a4c865a5286b2cde603898fd7e4a669e429855f1..d06539dff7cc9d21bdbdd1b16780201921d67e52 100644 (file)
@@ -939,7 +939,7 @@ static void msmsdcc_setup_gpio(struct msmsdcc_host *host, bool enable)
        struct msm_mmc_gpio_data *curr;
        int i, rc = 0;
 
-       if (!host->plat->gpio_data && host->gpio_config_status == enable)
+       if (!host->plat->gpio_data || host->gpio_config_status == enable)
                return;
 
        curr = host->plat->gpio_data;