projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
e8d34a8
)
driver/net/benet: fix be_cmd_multicast_set() memcpy bug
author
Joe Jin
<
[email protected]
>
Mon, 6 Dec 2010 03:00:59 +0000
(
03:00
+0000)
committer
David S. Miller
<
[email protected]
>
Wed, 8 Dec 2010 20:13:43 +0000
(12:13 -0800)
Regarding benet be_cmd_multicast_set() function, now using
netdev_for_each_mc_addr() helper for mac address copy, but
when copying to req->mac[] did not increase of the index.
Cc: Sathya Perla <
[email protected]
>
Cc: Subbu Seetharaman <
[email protected]
>
Cc: Sarveshwar Bandi <
[email protected]
>
Cc: Ajit Khaparde <
[email protected]
>
Signed-off-by: Joe Jin <
[email protected]
>
Signed-off-by: David S. Miller <
[email protected]
>
drivers/net/benet/be_cmds.c
patch
|
blob
|
history
diff --git
a/drivers/net/benet/be_cmds.c
b/drivers/net/benet/be_cmds.c
index 36eca1ce75d4e29a4c41bbf285931ce003a6a92a..e4465d222a7d019654c27c5f4d3db89067f89cf8 100644
(file)
--- a/
drivers/net/benet/be_cmds.c
+++ b/
drivers/net/benet/be_cmds.c
@@
-1235,7
+1235,7
@@
int be_cmd_multicast_set(struct be_adapter *adapter, u32 if_id,
i = 0;
netdev_for_each_mc_addr(ha, netdev)
- memcpy(req->mac[i].byte, ha->addr, ETH_ALEN);
+ memcpy(req->mac[i
++
].byte, ha->addr, ETH_ALEN);
} else {
req->promiscuous = 1;
}