btrfs: usage error should not be logged into system log

I have an opinion that system logs /var/log/messages are
valuable info to investigate the real system issues at
the data center. People handling data center issues
do spend a lot time and efforts analyzing messages
files. Having usage error logged into /var/log/messages
is something we should avoid.

Signed-off-by: Anand Jain <[email protected]>
Reviewed-by: David Sterba <[email protected]>
Signed-off-by: Chris Mason <[email protected]>

diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
index ba2a645dee07fce231158c2fa1d227a2ce607d7b..c0dfda5644f22b166584f1fa72704370cb0fd5a2 100644 (file)
--- a/fs/btrfs/sysfs.c
+++ b/fs/btrfs/sysfs.c
@@ -374,11 +374,8 @@ static ssize_t btrfs_label_store(struct kobject *kobj,
        struct btrfs_root *root = fs_info->fs_root;
        int ret;
 
-       if (len >= BTRFS_LABEL_SIZE) {
-               pr_err("BTRFS: unable to set label with more than %d bytes\n",
-                      BTRFS_LABEL_SIZE - 1);
+       if (len >= BTRFS_LABEL_SIZE)
                return -EINVAL;
-       }
 
        trans = btrfs_start_transaction(root, 0);
        if (IS_ERR(trans))