projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
1d53661
)
get_maintainer: repair STDIN usage
author
Wolfram Sang
<
[email protected]
>
Tue, 23 Mar 2010 20:35:18 +0000
(13:35 -0700)
committer
Linus Torvalds
<
[email protected]
>
Wed, 24 Mar 2010 23:31:20 +0000
(16:31 -0700)
Commit
22dd5b0cba50a197aaa3bd2790a29ee2e8e4e372
(fix perlcritic warnings)
broke the ability to handle STDIN because the three argument version of
open() cannot handle standard IO-streams (which is mentioned in
PerlBestPractices, too).
Signed-off-by: Wolfram Sang <
[email protected]
>
Cc: Stephen Hemminger <
[email protected]
>
Acked-by: Joe Perches <
[email protected]
>
Signed-off-by: Andrew Morton <
[email protected]
>
Signed-off-by: Linus Torvalds <
[email protected]
>
scripts/get_maintainer.pl
patch
|
blob
|
history
diff --git
a/scripts/get_maintainer.pl
b/scripts/get_maintainer.pl
index f76f3d13276dd114c880e13ec45cad7452f992b9..6f97a13bcee4131aedbbf97a4f9db49c50e519e5 100755
(executable)
--- a/
scripts/get_maintainer.pl
+++ b/
scripts/get_maintainer.pl
@@
-284,7
+284,7
@@
foreach my $file (@ARGV) {
my $file_cnt = @files;
my $lastfile;
- open(my $patch,
'<', $file
)
+ open(my $patch,
"< $file"
)
or die "$P: Can't open $file: $!\n";
while (<$patch>) {
my $patch_line = $_;