config: cap dhcpv6_pd_min_len to max instead of only logging error

Signed-off-by: Paul Donald <[email protected]>
Link: https://github.com/openwrt/odhcpd/pull/225
Signed-off-by: Álvaro Fernández Rojas <[email protected]>

diff --git a/src/config.c b/src/config.c
index 6792b5495e98e98086dbd64cb73b966af35133e8..2d8ff01eaacb8d31050676c6d5b574c8d78283aa 100644 (file)
--- a/src/config.c
+++ b/src/config.c
@@ -1303,11 +1303,12 @@ int config_parse_interface(void *data, size_t len, const char *name, bool overwr
 
        if ((c = tb[IFACE_ATTR_DHCPV6_PD_MIN_LEN])) {
                uint32_t pd_min_len = blobmsg_get_u32(c);
-               if (pd_min_len != 0 && pd_min_len <= PD_MIN_LEN_MAX)
-                       iface->dhcpv6_pd_min_len = pd_min_len;
-               else
-                       syslog(LOG_ERR, "Invalid %s value configured for interface '%s'",
-                                       iface_attrs[IFACE_ATTR_DHCPV6_PD_MIN_LEN].name, iface->name);
+               if (pd_min_len > PD_MIN_LEN_MAX)
+                       iface->dhcpv6_pd_min_len = PD_MIN_LEN_MAX;
+               iface->dhcpv6_pd_min_len = pd_min_len;
+               if (pd_min_len >= PD_MIN_LEN_MAX)
+                       syslog(LOG_WARNING, "Clamped invalid %s value configured for interface '%s' to %d",
+                                       iface_attrs[IFACE_ATTR_DHCPV6_PD_MIN_LEN].name, iface->name, iface->dhcpv6_pd_min_len);
        }
 
        if ((c = tb[IFACE_ATTR_DHCPV6_NA]))