drm/amd/pp: silence a static checker warning

This has a static checker warning because "frev" and "crev" can be
uninitialized if "info" is NULL.  I just changed the order of the checks
so that we check "info" first.

Reviewed-by: Rex Zhu <[email protected]>
Reviewed-by: Huang Rui <[email protected]>
Signed-off-by: Dan Carpenter <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c
index 75a465f771f0b029ab329511c84da155a9c83a4c..7b26607c646a1d8bf0dd816f28abfd66942c6fe6 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c
@@ -319,13 +319,13 @@ static int smu8_get_system_info_data(struct pp_hwmgr *hwmgr)
                        GetIndexIntoMasterTable(DATA, IntegratedSystemInfo),
                        &size, &frev, &crev);
 
-       if (crev != 9) {
-               pr_err("Unsupported IGP table: %d %d\n", frev, crev);
+       if (info == NULL) {
+               pr_err("Could not retrieve the Integrated System Info Table!\n");
                return -EINVAL;
        }
 
-       if (info == NULL) {
-               pr_err("Could not retrieve the Integrated System Info Table!\n");
+       if (crev != 9) {
+               pr_err("Unsupported IGP table: %d %d\n", frev, crev);
                return -EINVAL;
        }