block_invalidatepage(): only release page if the full page was invalidated
authorJeff Moyer <[email protected]>
Thu, 5 Apr 2018 23:25:01 +0000 (16:25 -0700)
committerLinus Torvalds <[email protected]>
Fri, 6 Apr 2018 04:36:27 +0000 (21:36 -0700)
Prior to commit d47992f86b30 ("mm: change invalidatepage prototype to
accept length"), an offset of 0 meant that the full page was being
invalidated.  After that commit, we need to instead check the length.

Jan said:
:
: The only possible issue is that try_to_release_page() was called more
: often than necessary.  Otherwise the issue is harmless but still it's good
: to have this fixed.

Link: http://lkml.kernel.org/r/[email protected]
Fixes: d47992f86b307 ("mm: change invalidatepage prototype to accept length")
Signed-off-by: Jeff Moyer <[email protected]>
Reviewed-by: Jan Kara <[email protected]>
Cc: Lukas Czerner <[email protected]>
Cc: Hugh Dickins <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
fs/buffer.c

index 9a73924db22f988df19662e45d534950a4c174f4..ec5dd39071e6a308c0c6eefea15d13db3bd6576d 100644 (file)
@@ -1511,7 +1511,7 @@ void block_invalidatepage(struct page *page, unsigned int offset,
         * The get_block cached value has been unconditionally invalidated,
         * so real IO is not possible anymore.
         */
-       if (offset == 0)
+       if (length == PAGE_SIZE)
                try_to_release_page(page, 0);
 out:
        return;