linux/kernel.h: use 'short' to define USHRT_MAX, SHRT_MAX, SHRT_MIN
authorMasahiro Yamada <[email protected]>
Fri, 8 Mar 2019 00:27:11 +0000 (16:27 -0800)
committerLinus Torvalds <[email protected]>
Fri, 8 Mar 2019 02:31:59 +0000 (18:31 -0800)
The commit log of 44f564a4bf6a ("ipc: add definitions of USHORT_MAX and
others") did not explain why it used (s16) and (u16) instead of (short)
and (unsigned short).

Let's use (short) and (unsigned short), which is more sensible, and more
consistent with the other MAX/MIN defines.

As you see in include/uapi/asm-generic/int-ll64.h, s16/u16 are
typedef'ed as signed/unsigned short.  So, this commit does not have a
functional change.

Remove the unneeded parentheses around ~0U while we are here.

Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Masahiro Yamada <[email protected]>
Cc: Alexey Dobriyan <[email protected]>
Cc: Zhang Yanmin <[email protected]>
Cc: Alex Elder <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
include/linux/kernel.h

index 43b4036e36fa04722d4adada9a5e1770a1b34577..a9ff66977e10f9a94f62ffcf04523867db38fb22 100644 (file)
@@ -17,9 +17,9 @@
 #include <asm/div64.h>
 #include <uapi/linux/kernel.h>
 
-#define USHRT_MAX      ((u16)(~0U))
-#define SHRT_MAX       ((s16)(USHRT_MAX>>1))
-#define SHRT_MIN       ((s16)(-SHRT_MAX - 1))
+#define USHRT_MAX      ((unsigned short)~0U)
+#define SHRT_MAX       ((short)(USHRT_MAX>>1))
+#define SHRT_MIN       ((short)(-SHRT_MAX - 1))
 #define INT_MAX                ((int)(~0U>>1))
 #define INT_MIN                (-INT_MAX - 1)
 #define UINT_MAX       (~0U)