efi: Add a comment about duplicated ELF constants
authorSimon Glass <[email protected]>
Tue, 12 Jun 2018 05:26:40 +0000 (23:26 -0600)
committerAlexander Graf <[email protected]>
Thu, 14 Jun 2018 08:52:14 +0000 (10:52 +0200)
These constants are defined in arch-specific code but redefined here. Add
a TODO to clean this up.

Signed-off-by: Simon Glass <[email protected]>
Reviewed-by: Heinrich Schuchardt <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
lib/efi_loader/efi_runtime.c

index 65f2bcf1401adaca95fc4a0335b0d21e12498d1f..4874eb602f79af93fd77d59bb311a89377e06c99 100644 (file)
@@ -28,6 +28,10 @@ static efi_status_t __efi_runtime EFIAPI efi_unimplemented(void);
 static efi_status_t __efi_runtime EFIAPI efi_device_error(void);
 static efi_status_t __efi_runtime EFIAPI efi_invalid_parameter(void);
 
+/*
+ * TODO([email protected]): These defines and structs should come from the elf
+ * header for each arch (or a generic header) rather than being repeated here.
+ */
 #if defined(CONFIG_ARM64)
 #define R_RELATIVE     1027
 #define R_MASK         0xffffffffULL