projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
dad48a4
)
S2io: two branches the same in wait_for_cmd_complete()
author
Ram Vepa
<
[email protected]
>
Tue, 19 Jan 2010 20:36:20 +0000
(12:36 -0800)
committer
David S. Miller
<
[email protected]
>
Tue, 19 Jan 2010 20:36:20 +0000
(12:36 -0800)
Fix check to verify if a register bit is set. We have not hit this bug because
wait_for_cmd_complete() is always called with S2IO_BIT_RESET.
Reported by Roel Kluin <
[email protected]
>.
Signed-off-by: Ram Vepa <
[email protected]
>
Signed-off-by: David S. Miller <
[email protected]
>
drivers/net/s2io.c
patch
|
blob
|
history
diff --git
a/drivers/net/s2io.c
b/drivers/net/s2io.c
index cc4218667cbad22db8ac13c6e83729caec0dbebf..3c4836d0898f310403f9d44e714793a127514df0 100644
(file)
--- a/
drivers/net/s2io.c
+++ b/
drivers/net/s2io.c
@@
-3421,7
+3421,7
@@
static int wait_for_cmd_complete(void __iomem *addr, u64 busy_bit,
break;
}
} else {
- if (
!(val64 & busy_bit)
) {
+ if (
val64 & busy_bit
) {
ret = SUCCESS;
break;
}