regulator: lp8788-ldo: Let core handle GPIO descriptor

Use the gpiod_get() rather than the devm_* version so that the
regulator core can handle the lifecycle of these descriptors.

Fixes: 2468f0d51548 ("regulator: lp8788-ldo: Pass descriptor instead of GPIO number")
Signed-off-by: Linus Walleij <[email protected]>
Reviewed-by: Marek Szyprowski <[email protected]>
Reviewed-by: Charles Keepax <[email protected]>
Signed-off-by: Mark Brown <[email protected]>

diff --git a/drivers/regulator/lp8788-ldo.c b/drivers/regulator/lp8788-ldo.c
index 553b4790050f6650a525155b64ccd4cc3c71a6e9..2ee22e7ea675671a6348f0c2c2eb413a8e0fa330 100644 (file)
--- a/drivers/regulator/lp8788-ldo.c
+++ b/drivers/regulator/lp8788-ldo.c
@@ -501,8 +501,12 @@ static int lp8788_config_ldo_enable_mode(struct platform_device *pdev,
                return 0;
        }
 
-       /* FIXME: check default mode for GPIO here: high or low? */
-       ldo->ena_gpiod = devm_gpiod_get_index_optional(&pdev->dev,
+       /*
+        * Do not use devm* here: the regulator core takes over the
+        * lifecycle management of the GPIO descriptor.
+        * FIXME: check default mode for GPIO here: high or low?
+        */
+       ldo->ena_gpiod = gpiod_get_index_optional(&pdev->dev,
                                               "enable",
                                               enable_id,
                                               GPIOD_OUT_HIGH |