projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5cd4f5c
)
cxl: Fix error handling in _cxl_cx4_setup_msi_irqs()
author
Christophe Jaillet
<
[email protected]
>
Sun, 30 Oct 2016 21:34:51 +0000
(22:34 +0100)
committer
Michael Ellerman
<
[email protected]
>
Fri, 18 Nov 2016 11:41:08 +0000
(22:41 +1100)
'cxl_dev_context_init()' returns an error pointer in case of error, not
NULL. So test it with IS_ERR.
Signed-off-by: Christophe JAILLET <
[email protected]
>
Reviewed-by: Andrew Donnellan <
[email protected]
>
Acked-by: Frederic Barrat <
[email protected]
>
Acked-by: Ian Munsie <
[email protected]
>
Signed-off-by: Michael Ellerman <
[email protected]
>
drivers/misc/cxl/api.c
patch
|
blob
|
history
diff --git
a/drivers/misc/cxl/api.c
b/drivers/misc/cxl/api.c
index 2b88ad8a2a89ecb676e78b28c64c6802bd5354a9..e2efc6489c6e1508fedc32b4716d53604b1bc2f8 100644
(file)
--- a/
drivers/misc/cxl/api.c
+++ b/
drivers/misc/cxl/api.c
@@
-538,7
+538,7
@@
int _cxl_cx4_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type)
if (remaining > 0) {
new_ctx = cxl_dev_context_init(pdev);
- if (
!new_ctx
) {
+ if (
IS_ERR(new_ctx)
) {
pr_warn("%s: Failed to allocate enough contexts for MSIs\n", pci_name(pdev));
return -ENOSPC;
}