perf callchain: Move callchain_param to util object in to fix python test
authorJiri Olsa <[email protected]>
Wed, 1 Oct 2014 16:00:26 +0000 (18:00 +0200)
committerArnaldo Carvalho de Melo <[email protected]>
Fri, 3 Oct 2014 12:39:48 +0000 (09:39 -0300)
In following commit we changed the location of callchains data:

  72a128aa083a7f4cc4f800718aaae05d9c698e26
  perf tools: Move callchain config from record_opts to callchain_param

Now all callchains stuff stays in callchain_param struct, which adds its
dependency for evsel.c object and breaks python perf.so usage
(unresolved callchain_param).

Moving callchain_param into callchain.c and adding it into
python-ext-sources unleash just another dependency hell, so I ended up
adding callchain_param into util.c for now.

Signed-off-by: Jiri Olsa <[email protected]>
Cc: Adrian Hunter <[email protected]>
Cc: Corey Ashford <[email protected]>
Cc: David Ahern <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Milian Wolff <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
tools/perf/util/hist.c
tools/perf/util/util.c

index 86569fa3651d00a851e9e38da54df647cc6ba17c..b47595697140b24ae5b8d95c70f876aa68ada9ae 100644 (file)
@@ -14,13 +14,6 @@ static bool hists__filter_entry_by_thread(struct hists *hists,
 static bool hists__filter_entry_by_symbol(struct hists *hists,
                                          struct hist_entry *he);
 
-struct callchain_param callchain_param = {
-       .mode   = CHAIN_GRAPH_REL,
-       .min_percent = 0.5,
-       .order  = ORDER_CALLEE,
-       .key    = CCKEY_FUNCTION
-};
-
 u16 hists__col_len(struct hists *hists, enum hist_column col)
 {
        return hists->col_len[col];
index 24e8d871b74e51d10ccf35fd8188901acf4a94df..d5eab3f3323ff42e4ac133878248b091a359f835 100644 (file)
 #include <byteswap.h>
 #include <linux/kernel.h>
 #include <unistd.h>
+#include "callchain.h"
+
+struct callchain_param callchain_param = {
+       .mode   = CHAIN_GRAPH_REL,
+       .min_percent = 0.5,
+       .order  = ORDER_CALLEE,
+       .key    = CCKEY_FUNCTION
+};
 
 /*
  * XXX We need to find a better place for these things...