Revert "scsi: core: fix scsi_host_queue_ready"
authorMing Lei <[email protected]>
Mon, 27 Aug 2018 07:24:42 +0000 (15:24 +0800)
committerMartin K. Petersen <[email protected]>
Mon, 27 Aug 2018 16:59:43 +0000 (12:59 -0400)
This reverts commit 265d59aacbce7e50bdc1f5d25033c38dd70b3767.

There is fundamental issue in commit 328728630d9f2bf1 (scsi: core: avoid
host-wide host_busy counter for scsi_mq) because SCSI's host busy counter
may not be same with counter of blk-mq's inflight tags, especially in case
of none io scheduler.

So revert this commit first.

Cc: Omar Sandoval <[email protected]>,
Cc: "Martin K. Petersen" <[email protected]>,
Cc: James Bottomley <[email protected]>,
Cc: Christoph Hellwig <[email protected]>,
Cc: Don Brace <[email protected]>
Cc: Kashyap Desai <[email protected]>
Cc: Mike Snitzer <[email protected]>
Cc: Hannes Reinecke <[email protected]>
Cc: Laurence Oberman <[email protected]>
Cc: Bart Van Assche <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Jens Axboe <[email protected]>
Reported-by: Jens Axboe <[email protected]>
Signed-off-by: Ming Lei <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
drivers/scsi/scsi_lib.c

index 0adfb3bce0fd677ddae9f9d806472ccf2077ce25..1046679f5473c0ea8f2152c3c0603de217f768a1 100644 (file)
@@ -1611,7 +1611,7 @@ static inline int scsi_host_queue_ready(struct request_queue *q,
        else
                busy = 0;
        if (atomic_read(&shost->host_blocked) > 0) {
-               if (busy)
+               if (busy || scsi_host_busy(shost))
                        goto starved;
 
                /*