drm: Make the fb refcount handover less magic

Instead of assigning the plane->fb pointer and clearing the fb pointer
to hand over the reference, let's just do it by grabbing another
referece for plane->fb and let fb keep its original one.

Signed-off-by: Ville Syrjälä <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Reviewed-by: Daniel Vetter <[email protected]>
Reviewed-by: Maarten Lankhorst <[email protected]>

diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c
index bedceca7dd06cc4a82d8f3f93adacd10bda04dd4..008f9456a5e840bfbc99c159ac6a7e5e087604c7 100644 (file)
--- a/drivers/gpu/drm/drm_plane.c
+++ b/drivers/gpu/drm/drm_plane.c
@@ -1084,8 +1084,7 @@ retry:
                plane->old_fb = NULL;
        } else {
                plane->fb = fb;
-               /* Unref only the old framebuffer. */
-               fb = NULL;
+               drm_framebuffer_get(fb);
        }
 
 out: