projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
23535c1
)
staging: wilc1000: NULL dereference on error
author
Dan Carpenter
<
[email protected]
>
Sat, 16 Jul 2016 10:07:55 +0000
(13:07 +0300)
committer
Greg Kroah-Hartman
<
[email protected]
>
Sun, 21 Aug 2016 15:28:21 +0000
(17:28 +0200)
We can't pass NULL pointers to destroy_workqueue().
Signed-off-by: Dan Carpenter <
[email protected]
>
Signed-off-by: Greg Kroah-Hartman <
[email protected]
>
drivers/staging/wilc1000/host_interface.c
patch
|
blob
|
history
diff --git
a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
index 0b1760cba6e35a77fc391f44f9cfc7c263b9e254..78f524fcd2142dd486d20aba5fe75f461cc5f466 100644
(file)
--- a/
drivers/staging/wilc1000/host_interface.c
+++ b/
drivers/staging/wilc1000/host_interface.c
@@
-3363,7
+3363,7
@@
int wilc_init(struct net_device *dev, struct host_if_drv **hif_drv_handler)
if (!hif_workqueue) {
netdev_err(vif->ndev, "Failed to create workqueue\n");
result = -ENOMEM;
- goto _fail_
mq_
;
+ goto _fail_;
}
setup_timer(&periodic_rssi, GetPeriodicRSSI,
@@
-3391,7
+3391,6
@@
int wilc_init(struct net_device *dev, struct host_if_drv **hif_drv_handler)
clients_count++;
-_fail_mq_:
destroy_workqueue(hif_workqueue);
_fail_:
return result;