smsc75xx: don't call usbnet_resume if usbnet_suspend fails

If usbnet_suspend returns an error we don't want to call
usbnet_resume to clean up, but instead just return the error.

If usbnet_suspend *does* succeed, and we have a problem further
on, the desired behaviour is still to call usbnet_resume
to clean up before returning.

Signed-off-by: Steve Glendinning <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

diff --git a/drivers/net/usb/smsc75xx.c b/drivers/net/usb/smsc75xx.c
index 18238060f1c087ee0d5a8b4990144b841c56ff4b..86d924951d2e42a37d5bbdaa4e8bf4d9b283394f 100644 (file)
--- a/drivers/net/usb/smsc75xx.c
+++ b/drivers/net/usb/smsc75xx.c
@@ -1411,7 +1411,7 @@ static int smsc75xx_suspend(struct usb_interface *intf, pm_message_t message)
        int ret;
 
        ret = usbnet_suspend(intf, message);
-       check_warn_goto_done(ret, "usbnet_suspend error\n");
+       check_warn_return(ret, "usbnet_suspend error\n");
 
        if (pdata->suspend_flags) {
                netdev_warn(dev->net, "error during last resume\n");