projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
82d627c
)
fs/ocfs2/dlm/dlmrecovery.c:dlm_request_all_locks(): ret should be int instead of...
author
Joseph Qi
<
[email protected]
>
Wed, 3 Jul 2013 22:00:47 +0000
(15:00 -0700)
committer
Linus Torvalds
<
[email protected]
>
Wed, 3 Jul 2013 23:07:23 +0000
(16:07 -0700)
In dlm_request_all_locks, ret is type enum. But o2net_send_message
returns a type int value. Then it will never run into the following
error branch. So we should change the ret type from enum to int.
Signed-off-by: Joseph Qi <
[email protected]
>
Cc: Joel Becker <
[email protected]
>
Cc: Mark Fasheh <
[email protected]
>
Acked-by: Sunil Mushran <
[email protected]
>
Signed-off-by: Andrew Morton <
[email protected]
>
Signed-off-by: Linus Torvalds <
[email protected]
>
fs/ocfs2/dlm/dlmrecovery.c
patch
|
blob
|
history
diff --git
a/fs/ocfs2/dlm/dlmrecovery.c
b/fs/ocfs2/dlm/dlmrecovery.c
index 3e18641626b48fc197ae23882deea98d7f305139..53e5c0284fa258651323d0c8c2ab221a3621c97c 100644
(file)
--- a/
fs/ocfs2/dlm/dlmrecovery.c
+++ b/
fs/ocfs2/dlm/dlmrecovery.c
@@
-786,7
+786,7
@@
static int dlm_request_all_locks(struct dlm_ctxt *dlm, u8 request_from,
u8 dead_node)
{
struct dlm_lock_request lr;
-
enum dlm_status
ret;
+
int
ret;
mlog(0, "\n");
@@
-799,7
+799,6
@@
static int dlm_request_all_locks(struct dlm_ctxt *dlm, u8 request_from,
lr.dead_node = dead_node;
// send message
- ret = DLM_NOLOCKMGR;
ret = o2net_send_message(DLM_LOCK_REQUEST_MSG, dlm->key,
&lr, sizeof(lr), request_from, NULL);