drm/i915: Add a FIXME about drrs/psr interactions

Can't review this right now due to lack of DRRS code.

Reviewed-by: Rodrigo Vivi <[email protected]>
Cc: Vandana Kannan <[email protected]>
Signed-off-by: Daniel Vetter <[email protected]>

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 6359005180f014582c240660c2b822280546dcf4..4017406b810d14153c25254cfe54b0d1a1eec440 100644 (file)
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4104,6 +4104,11 @@ void intel_dp_set_drrs_state(struct drm_device *dev, int refresh_rate)
                return;
        }
 
+       /*
+        * FIXME: This needs proper synchronization with psr state. But really
+        * hard to tell without seeing the user of this function of this code.
+        * Check locking and ordering once that lands.
+        */
        if (INTEL_INFO(dev)->gen < 8 && intel_edp_is_psr_enabled(dev)) {
                DRM_DEBUG_KMS("DRRS is disabled as PSR is enabled\n");
                return;