projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b0b46c7
)
bnx2x: Fix static checker warning regarding `txdata_ptr'
author
Yuval Mintz
<
[email protected]
>
Tue, 26 Aug 2014 07:24:41 +0000
(10:24 +0300)
committer
David S. Miller
<
[email protected]
>
Wed, 27 Aug 2014 23:28:46 +0000
(16:28 -0700)
Incorrect checking of array instead of array contents in panic_dump
flow - results of commit
e261199872a2
("bnx2x: Safe bnx2x_panic_dump()").
Reported-by: Dan Carpenter <
[email protected]
>
Signed-off-by: Yuval Mintz <
[email protected]
>
Signed-off-by: David S. Miller <
[email protected]
>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
patch
|
blob
|
history
diff --git
a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index 2f394b82ca026684e998c78e26aabcb1e663934e..93132d8fec671b9e6a0858c19c2aa33519e73210 100644
(file)
--- a/
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@
-985,7
+985,7
@@
void bnx2x_panic_dump(struct bnx2x *bp, bool disable_int)
/* Tx */
for_each_cos_in_tx_queue(fp, cos)
{
- if (!fp->txdata_ptr)
+ if (!fp->txdata_ptr
[cos]
)
break;
txdata = *fp->txdata_ptr[cos];
@@
-1140,7
+1140,7
@@
void bnx2x_panic_dump(struct bnx2x *bp, bool disable_int)
for_each_cos_in_tx_queue(fp, cos) {
struct bnx2x_fp_txdata *txdata = fp->txdata_ptr[cos];
- if (!fp->txdata_ptr)
+ if (!fp->txdata_ptr
[cos]
)
break;
if (!txdata->tx_cons_sb)