perf probe: Make a copy of exec path for passing to basename

The basename function may modify the string passed to it, so the string
should not be marked const.

Signed-off-by: David Ahern <[email protected]>
Acked-by: Pekka Enberg <[email protected]>
Cc: Irina Tirdea <[email protected]>
Cc: Pekka Enberg <[email protected]>
Cc: Srikar Dronamraju <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 0dda25d82d06ff81d55be2eb6529e970e4a3cd07..e8c72de0f70cd78215b1034d1d5bdda3049574b1 100644 (file)
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -2307,10 +2307,17 @@ static int convert_name_to_addr(struct perf_probe_event *pev, const char *exec)
                function = NULL;
        }
        if (!pev->group) {
-               char *ptr1, *ptr2;
+               char *ptr1, *ptr2, *exec_copy;
 
                pev->group = zalloc(sizeof(char *) * 64);
-               ptr1 = strdup(basename(exec));
+               exec_copy = strdup(exec);
+               if (!exec_copy) {
+                       ret = -ENOMEM;
+                       pr_warning("Failed to copy exec string.\n");
+                       goto out;
+               }
+
+               ptr1 = strdup(basename(exec_copy));
                if (ptr1) {
                        ptr2 = strpbrk(ptr1, "-._");
                        if (ptr2)
@@ -2319,6 +2326,7 @@ static int convert_name_to_addr(struct perf_probe_event *pev, const char *exec)
                                        ptr1);
                        free(ptr1);
                }
+               free(exec_copy);
        }
        free(pp->function);
        pp->function = zalloc(sizeof(char *) * MAX_PROBE_ARGS);