v4l: vsp1: Fill display list headers without holding dlm spinlock

The display list headers are filled using information from the display
list only. Lower the display list manager spinlock contention by filling
the headers without holding the lock.

Signed-off-by: Laurent Pinchart <[email protected]>
Reviewed-by: Kieran Bingham <[email protected]>
Acked-by: Mauro Carvalho Chehab <[email protected]>

diff --git a/drivers/media/platform/vsp1/vsp1_dl.c b/drivers/media/platform/vsp1/vsp1_dl.c
index aaf17b13fd7875f29c6c966e4caae234cb4d29e6..dc47e236c780da70011ee2749f5c352f77105349 100644 (file)
--- a/drivers/media/platform/vsp1/vsp1_dl.c
+++ b/drivers/media/platform/vsp1/vsp1_dl.c
@@ -483,8 +483,6 @@ void vsp1_dl_list_commit(struct vsp1_dl_list *dl)
        unsigned long flags;
        bool update;
 
-       spin_lock_irqsave(&dlm->lock, flags);
-
        if (dl->dlm->mode == VSP1_DL_MODE_HEADER) {
                struct vsp1_dl_list *dl_child;
 
@@ -501,7 +499,11 @@ void vsp1_dl_list_commit(struct vsp1_dl_list *dl)
 
                        vsp1_dl_list_fill_header(dl_child, last);
                }
+       }
 
+       spin_lock_irqsave(&dlm->lock, flags);
+
+       if (dl->dlm->mode == VSP1_DL_MODE_HEADER) {
                /*
                 * Commit the head display list to hardware. Chained headers
                 * will auto-start.