ALSA: ctxf: Use kcalloc instead of kzalloc to allocate array

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>

diff --git a/sound/pci/ctxfi/ctsrc.c b/sound/pci/ctxfi/ctsrc.c
index e134b3a5780da709d9ccbf3fce4c9f99f7f82fc5..6e77e86307c2c90fd8ca8d3dde53dceebd0499af 100644 (file)
--- a/sound/pci/ctxfi/ctsrc.c
+++ b/sound/pci/ctxfi/ctsrc.c
@@ -437,7 +437,7 @@ get_src_rsc(struct src_mgr *mgr, const struct src_desc *desc, struct src **rsrc)
 
        /* Allocate mem for master src resource */
        if (MEMRD == desc->mode)
-               src = kzalloc(sizeof(*src)*desc->multi, GFP_KERNEL);
+               src = kcalloc(desc->multi, sizeof(*src), GFP_KERNEL);
        else
                src = kzalloc(sizeof(*src), GFP_KERNEL);