x86/mid/thermal: Turn off thermistor

Instead of complaining that the voltage is on, we can just ask
the MSIC to turn the voltage off. This should save some power.

Voltage for thermistors is turned on when ADC conversion is
initiated.

Signed-off-by: Mika Westerberg <[email protected]>
Signed-off-by: Kirill A. Shutemov <[email protected]>
Signed-off-by: Alan Cox <[email protected]>
Acked-by: Durgadoss R <[email protected]>
Acked-by: H. Peter Anvin <[email protected]>
Cc: Matthew Garrett <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Link: http://lkml.kernel.org/n/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>

diff --git a/drivers/platform/x86/intel_mid_thermal.c b/drivers/platform/x86/intel_mid_thermal.c
index 5917b3c837288ff9122d8630a5cd4e5ab27b2c9e..2ee9766737ea413d56e82d581444c64f1b696801 100644 (file)
--- a/drivers/platform/x86/intel_mid_thermal.c
+++ b/drivers/platform/x86/intel_mid_thermal.c
@@ -360,8 +360,10 @@ static int mid_initialize_adc(struct device *dev)
        if (ret)
                return ret;
 
-       if (data & MSIC_ADCTHERM_MASK)
-               dev_warn(dev, "ADCTHERM already set");
+       data &= ~MSIC_ADCTHERM_MASK;
+       ret = intel_msic_reg_write(INTEL_MSIC_ADC1CNTL3, data);
+       if (ret)
+               return ret;
 
        /* Index of the first channel in which the stop bit is set */
        channel_index = find_free_channel();