[SUNRPC]: Remove unnecessary check in net/sunrpc/svcsock.c

coverity spotted this one as possible dereference in the dprintk(),
but since there is only one caller of svc_create_socket(), which always
passes a valid sin, we dont need this check.

Signed-off-by: Eric Sesterhenn <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
index f09f7487051f34ba2c42be0c64c6d92f0be2f792..5b0fe1b66a23d5fbed578179268bedc15eae52c2 100644 (file)
--- a/net/sunrpc/svcsock.c
+++ b/net/sunrpc/svcsock.c
@@ -1393,14 +1393,12 @@ svc_create_socket(struct svc_serv *serv, int protocol, struct sockaddr_in *sin)
        if ((error = sock_create_kern(PF_INET, type, protocol, &sock)) < 0)
                return error;
 
-       if (sin != NULL) {
-               if (type == SOCK_STREAM)
-                       sock->sk->sk_reuse = 1; /* allow address reuse */
-               error = kernel_bind(sock, (struct sockaddr *) sin,
-                                               sizeof(*sin));
-               if (error < 0)
-                       goto bummer;
-       }
+       if (type == SOCK_STREAM)
+               sock->sk->sk_reuse = 1; /* allow address reuse */
+       error = kernel_bind(sock, (struct sockaddr *) sin,
+                                       sizeof(*sin));
+       if (error < 0)
+               goto bummer;
 
        if (protocol == IPPROTO_TCP) {
                if ((error = kernel_listen(sock, 64)) < 0)