Staging: wlan-ng: p80211wext.c: problem with IW_ENCODE_ALG_WEP

The expression !(ext->alg & IW_ENCODE_ALG_WEP) appears to be incorrect,
because there are several possible values for ext->alg that give 1 when
bit-anded with IW_ENCODE_ALG_WEP.  Therefore Richard Kennedy suggested to
rewrite the code with !=

Added \n at the end of the debug string as well.

Signed-off-by: Julia Lawall <[email protected]>
Cc: Jiri Slaby <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

diff --git a/drivers/staging/wlan-ng/p80211wext.c b/drivers/staging/wlan-ng/p80211wext.c
index 3a96fce7c22e5f6f384f569058ac1c90fd896e85..e73123b26df730f70b4215442326cdcf8e9c1802 100644 (file)
--- a/drivers/staging/wlan-ng/p80211wext.c
+++ b/drivers/staging/wlan-ng/p80211wext.c
@@ -1487,8 +1487,8 @@ static int p80211wext_set_encodeext(struct net_device *dev,
        }
 
        if (ext->ext_flags & IW_ENCODE_EXT_SET_TX_KEY) {
-               if (!(ext->alg & IW_ENCODE_ALG_WEP)) {
-                       pr_debug("asked to set a non wep key :(");
+               if (ext->alg != IW_ENCODE_ALG_WEP) {
+                       pr_debug("asked to set a non wep key :(\n");
                        return -EINVAL;
                }
                if (idx) {