smackfs load append mode fix

Given just how hard it is to find the code that uses MAY_APPEND
it's probably not a big surprise that this went unnoticed for so
long. The Smack rules loading code is incorrectly setting the
MAY_READ bit when MAY_APPEND is requested.

Signed-off-by: Casey Schaufler <[email protected]>
Reviewed-by: James Morris <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
index 71e2b914363e2cf5490fe9698b7bd76fa23eb9c9..8e42800878f468912c56cece9336e7c8c6bfa727 100644 (file)
--- a/security/smack/smackfs.c
+++ b/security/smack/smackfs.c
@@ -334,7 +334,7 @@ static ssize_t smk_write_load(struct file *file, const char __user *buf,
                break;
        case 'a':
        case 'A':
-               rule.smk_access |= MAY_READ;
+               rule.smk_access |= MAY_APPEND;
                break;
        default:
                goto out;