realtek: dsa: Drop LAG checks already handled by DSA handlers
authorSven Eckelmann <[email protected]>
Sun, 9 Nov 2025 08:32:03 +0000 (09:32 +0100)
committerHauke Mehrtens <[email protected]>
Tue, 11 Nov 2025 00:06:49 +0000 (01:06 +0100)
There is no need to check conditions in rtl83xx_lag_add()/rtl83xx_lag_del()
when they are already checked in
rtl83xx_port_lag_join()/rtl83xx_port_lag_leave().

Signed-off-by: Sven Eckelmann <[email protected]>
Link: https://github.com/openwrt/openwrt/pull/20707
Signed-off-by: Hauke Mehrtens <[email protected]>
target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/common.c

index dc588d40d40c7c2246b69f0db260eed988d6394b..59abba780755807af83ccd462e8e3f56eb3751fc 100644 (file)
@@ -452,21 +452,6 @@ int rtl83xx_lag_add(struct dsa_switch *ds, int group, int port, struct netdev_la
        u32 algomsk = 0;
        u32 algoidx = 0;
 
-       if (info->tx_type != NETDEV_LAG_TX_TYPE_HASH) {
-               pr_err("%s: Only mode LACP 802.3ad (4) allowed.\n", __func__);
-               return -EINVAL;
-       }
-
-       if (group >= priv->ds->num_lag_ids) {
-               pr_err("%s: LAG %d invalid.\n", __func__, group);
-               return -EINVAL;
-       }
-
-       if (port >= priv->cpu_port) {
-               pr_err("%s: Port %d invalid.\n", __func__, port);
-               return -EINVAL;
-       }
-
        for (i = 0; i < priv->ds->num_lag_ids; i++) {
                if (priv->lags_port_members[i] & BIT_ULL(port))
                        break;
@@ -518,11 +503,6 @@ int rtl83xx_lag_del(struct dsa_switch *ds, int group, int port)
                return -EINVAL;
        }
 
-       if (port >= priv->cpu_port) {
-               pr_err("%s: Port %d invalid.\n", __func__, port);
-               return -EINVAL;
-       }
-
        if (!(priv->lags_port_members[group] & BIT_ULL(port))) {
                pr_err("%s: Port %d not member of LAG %d.\n", __func__, port, group);
                return -ENOSPC;