bonding: use rtnl_deref in bond_change_rx_flags()

As it's always called with RTNL held, via dev_set_allmulti/promiscuity.
Also, remove the wrong comment.

CC: Jay Vosburgh <[email protected]>
CC: Andy Gospodarek <[email protected]>
Signed-off-by: Veaceslav Falico <[email protected]>
Acked-by: Eric Dumazet <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index a2c4e8d4a9559fbdfa7806d9cbcceb76d7a29975..5e5b3b30c51c2f1ba4786d1104dfa96bee85de85 100644 (file)
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -496,9 +496,8 @@ static int bond_set_promiscuity(struct bonding *bond, int inc)
        int err = 0;
 
        if (bond_uses_primary(bond)) {
-               struct slave *curr_active = bond_deref_active_protected(bond);
+               struct slave *curr_active = rtnl_dereference(bond->curr_active_slave);
 
-               /* write lock already acquired */
                if (curr_active)
                        err = dev_set_promiscuity(curr_active->dev, inc);
        } else {
@@ -522,9 +521,8 @@ static int bond_set_allmulti(struct bonding *bond, int inc)
        int err = 0;
 
        if (bond_uses_primary(bond)) {
-               struct slave *curr_active = bond_deref_active_protected(bond);
+               struct slave *curr_active = rtnl_dereference(bond->curr_active_slave);
 
-               /* write lock already acquired */
                if (curr_active)
                        err = dev_set_allmulti(curr_active->dev, inc);
        } else {