net: ethernet: bgmac: Fix return value check in bgmac_probe()

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().

Signed-off-by: Wei Yongjun <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

diff --git a/drivers/net/ethernet/broadcom/bgmac-platform.c b/drivers/net/ethernet/broadcom/bgmac-platform.c
index 7a8f7effe2a63cf584af6090f92d6e53efc6b4d0..1a2d8418e7c1783c57d6534838388b758c886c21 100644 (file)
--- a/drivers/net/ethernet/broadcom/bgmac-platform.c
+++ b/drivers/net/ethernet/broadcom/bgmac-platform.c
@@ -141,7 +141,7 @@ static int bgmac_probe(struct platform_device *pdev)
        }
 
        bgmac->plat.idm_base = devm_ioremap_resource(&pdev->dev, regs);
-       if (!bgmac->plat.idm_base) {
+       if (IS_ERR(bgmac->plat.idm_base)) {
                dev_err(&pdev->dev, "Unable to map idm resource\n");
                return PTR_ERR(bgmac->plat.idm_base);
        }