modules, tracing: Remove stale struct marker signature from module_layout()
authorIngo Molnar <[email protected]>
Mon, 21 Sep 2009 16:22:11 +0000 (18:22 +0200)
committerIngo Molnar <[email protected]>
Wed, 23 Sep 2009 08:34:21 +0000 (10:34 +0200)
Linus reported this new build warning:

  kernel/module.c:2951: warning: ?struct marker? declared inside parameter list
  kernel/module.c:2951: warning: its scope is only this definition or declaration, which is probably not what you want

Caused by:

  fc53776: tracing: Remove markers

module_layout() is an artificial symbol with 'significant' symbols
listed in its argument list so that it gets a proper argument types
signature that modversions can pick up to decide whether a
module is version-compatible or not. If these dont match then we
wont even look at a module.

Remove the stale marker symbol.

Reported-by: Linus Torvalds <[email protected]>
LKML-Reference: <alpine.LFD.2.01.0909210908020[email protected]>
Cc: Christoph Hellwig <[email protected]>
Cc: Mathieu Desnoyers <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Rusty Russell <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
kernel/module.c

index b6ee424245dd15b00a1b246388733a76b392041a..392eb3defbcd553149d07246d31c7b2cca1cc595 100644 (file)
@@ -2947,7 +2947,6 @@ void module_layout(struct module *mod,
                   struct modversion_info *ver,
                   struct kernel_param *kp,
                   struct kernel_symbol *ks,
-                  struct marker *marker,
                   struct tracepoint *tp)
 {
 }